rdblue commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1125752935
##########
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##########
@@ -192,6 +196,15 @@ public Builder withMetrics(Metrics metrics) {
return this;
}
+ public Builder withSplitOffsets(List<Long> offsets) {
+ if (offsets != null) {
+ this.splitOffsets = copyList(offsets);
Review Comment:
I think this should use `ImmutableLists.copyOf` instead of adding a copy
method just to create a mutable list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
