rdblue commented on PR #7011: URL: https://github.com/apache/iceberg/pull/7011#issuecomment-1460372628
This looks fine to me overall, but I'd prefer to use `ImmutableList` or `long[]` for split offsets in the builder to avoid an unnecessary new util class and copy method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
