rdblue commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1129646406
##########
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##########
@@ -192,6 +196,15 @@ public Builder withMetrics(Metrics metrics) {
return this;
}
+ public Builder withSplitOffsets(List<Long> offsets) {
+ if (offsets != null) {
+ this.splitOffsets = copyList(offsets);
Review Comment:
Sorry, this was my bad. I didn't realize that this `copyList` was behavior
was already present. Looks like a later change to `BaseFile` converted the
offsets to `long[]` so I don't think this is actually needed anymore. I think
we could use `ImmutableList.copyOf` and have the Kryo tests pass. Not a big
deal though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
