danielcweeks commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1142647907
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -143,11 +143,11 @@ public String newDataLocation(PartitionSpec spec,
StructLike partitionData, Stri
@Override
public String newDataLocation(String filename) {
- int hash = HASH_FUNC.apply(filename);
+ String hash = computeHash(filename);
Review Comment:
I don't think that's a good idea. If someone has a custom list operation,
then they're relying on behaviors of the implementation and take the risk that
something like this will break their implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
