danielcweeks commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1142700720
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +167,14 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
+ Preconditions.checkState(fileName != null, "fileName cannot be null");
+ byte[] messageDigest =
+
HASH_FUNC.hashBytes(fileName.getBytes(StandardCharsets.UTF_8)).asBytes();
+ String hash = Base64.getUrlEncoder().encodeToString(messageDigest);
+
+ return hash.substring(0, 8);
Review Comment:
Seems like we could just start off with a 6 byte buffer, stuff it with
random bytes and then copy the hash bytes to the front. That would produce a
hash without padding:
```java
byte [] hashBuffer = new byte[6];
random.nextBytes(hashBuffer);
byte[] messageDigest =
HASH_FUNC.hashBytes(fileName.getBytes(StandardCharsets.UTF_8)).asBytes();
System.arrayCopy(messageDigest, 0, hashBuffer, 0, 4);
String hash = Base64.getUrlEncoder().encodeToString(hashBuffer);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
