danielcweeks commented on code in PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#discussion_r1142691916
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -167,5 +167,14 @@ private static String pathContext(String tableLocation) {
return resolvedContext;
}
+
+ private static String computeHash(String fileName) {
+ Preconditions.checkState(fileName != null, "fileName cannot be null");
+ byte[] messageDigest =
+
HASH_FUNC.hashBytes(fileName.getBytes(StandardCharsets.UTF_8)).asBytes();
+ String hash = Base64.getUrlEncoder().encodeToString(messageDigest);
+
+ return hash.substring(0, 8);
Review Comment:
I think it always ends up being 8 characters after the Base64 encoding, but
that's only because of the padding. We need to address the base64 padding
characters, but you might be able to just stuff bytes to get there.
Alternatively, we could just drop/replace those characters since they will
always come at the end of the hash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
