hililiwei commented on code in PR #7571:
URL: https://github.com/apache/iceberg/pull/7571#discussion_r1189454683


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -458,7 +468,12 @@ public IcebergSource<T> build() {
       checkRequired();
       // Since builder already load the table, pass it to the source to avoid 
double loading
       return new IcebergSource<T>(
-          tableLoader, context, readerFunction, splitAssignerFactory, table);
+          tableLoader,
+          context,
+          readerFunction,
+          splitAssignerFactory,
+          flinkReadConf.planRetryNum(),

Review Comment:
   But this is not entirely true. For example, `monitorInterval`, which is used 
to configure the monitoring interval, and `exposeLocality`, `planParallelism`, 
which are only for Flink.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to