hililiwei commented on code in PR #7571:
URL: https://github.com/apache/iceberg/pull/7571#discussion_r1189462306
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -458,7 +468,12 @@ public IcebergSource<T> build() {
checkRequired();
// Since builder already load the table, pass it to the source to avoid
double loading
return new IcebergSource<T>(
- tableLoader, context, readerFunction, splitAssignerFactory, table);
+ tableLoader,
+ context,
+ readerFunction,
+ splitAssignerFactory,
+ flinkReadConf.planRetryNum(),
Review Comment:
By the way, I once thought about deleting `ScanContext`, because we can use
`flinkReadConf` to uniformly parse these parameters, but it was not achieved
due to serialization issues. Maybe we can reconsider simplifying this part of
the logic, removing `ScanContext`. Of course, this is not what this PR needs to
pay attention to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
