hililiwei commented on code in PR #7571:
URL: https://github.com/apache/iceberg/pull/7571#discussion_r1189669699
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -426,7 +432,8 @@ public IcebergSource<T> build() {
}
}
- contextBuilder.resolveConfig(table, readOptions, flinkConfig);
+ FlinkReadConf flinkReadConf = new FlinkReadConf(table, readOptions,
flinkConfig);
+ contextBuilder.resolveConfig(flinkReadConf);
Review Comment:
Since we have changed to `ScanContext`, the modification here seems
meaningless, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
