aokolnychyi commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1199476069
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -1742,7 +2516,7 @@ public void
testRangePositionDeltaUpdatePartitionedTable() {
// LOCALLY ORDERED BY _spec_id, _partition, _file,
_pos, date, days(ts)
// merge mode is HASH -> CLUSTER BY _spec_id, _partition, date, days(ts) +
// LOCALLY ORDER BY _spec_id, _partition, _file, _pos,
date, days(ts)
- // merge mode is RANGE -> RANGE DISTRIBUTE BY _spec_id, _partition, _file,
date, days(ts) +
Review Comment:
This may be debatable. We initially included `_file` to split the deletes if
too many but AQE should be a better option we are sure we won't split deletes
per partition unless needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
