amogh-jahagirdar commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1200687361
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -91,6 +105,42 @@ public void dropTable() {
sql("DROP TABLE IF EXISTS %s", tableName);
}
+ // =============================================================
+ // Distribution and ordering for write operations such as APPEND
+ // =============================================================
+ //
+ // UNPARTITIONED UNORDERED
+ // -------------------------------------------------------------------------
+ // write mode is NOT SET -> unspecified distribution + empty ordering
+ // write mode is NONE -> unspecified distribution + empty ordering
+ // write mode is HASH -> unspecified distribution + empty ordering
+ // write mode is RANGE -> unspecified distribution + empty ordering
+ //
+ // UNPARTITIONED ORDERED BY id, data
+ // -------------------------------------------------------------------------
+ // write mode is NOT SET -> ORDER BY id, data
+ // write mode is NONE -> unspecified distribution + LOCALLY ORDER BY id, data
+ // write mode is HASH -> unspecified distribution + LOCALLY ORDER BY id, data
+ // write mode is RANGE -> ORDER BY id, data
+ //
+ // PARTITIONED BY date, days(ts) UNORDERED
+ // -------------------------------------------------------------------------
+ // write mode is NOT SET -> CLUSTER BY date, days(ts) + LOCALLY ORDER BY
date, days(ts)
+ // write mode is NOT SET (fanout) -> CLUSTER BY date, days(ts) + empty
ordering
+ // write mode is NONE -> unspecified distribution + LOCALLY ORDERED BY date,
days(ts)
+ // write mode is NONE (fanout) -> unspecified distribution + empty ordering
Review Comment:
Curious, would it be useful to have all these distribution and ordering
examples accessible in our public docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
