RussellSpitzer commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1200824672
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -319,11 +378,12 @@ public DistributionMode
positionDeltaMergeDistributionMode() {
return DistributionMode.fromName(mergeModeName);
}
- public boolean useTableDistributionAndOrdering() {
+ private boolean ignoreTableDistributionAndOrdering() {
return confParser
.booleanConf()
.option(SparkWriteOptions.USE_TABLE_DISTRIBUTION_AND_ORDERING)
.defaultValue(SparkWriteOptions.USE_TABLE_DISTRIBUTION_AND_ORDERING_DEFAULT)
+ .negate()
Review Comment:
This makes me slightly apprehensive, since I don't like flipping the sign in
the builder. I do think it's cleaner than just adding a ! to the return
statement though so +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
