nastra commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238643515
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -404,14 +444,14 @@ public void testCanReadOldCompressedManifestFiles()
throws Exception {
Table reloaded = TABLES.load(tableLocation);
List<FileScanTask> tasks =
Lists.newArrayList(reloaded.newScan().planFiles());
- Assert.assertEquals("Should scan 1 files", 1, tasks.size());
+ Assertions.assertThat(tasks).as("Should scan 1 files").hasSize(1);
}
@Test
public void testConcurrentFastAppends() throws Exception {
assertTrue("Should create v1 metadata", version(1).exists() &&
version(1).isFile());
- File dir = temp.newFolder();
- dir.delete();
+ File dir = tableDir;
+ FileUtils.deleteDirectory(dir);
Review Comment:
then it's probably better to inject a separate temp dir for this particular
test using `testConcurrentFastAppends(@TempDir File dir)` as a method parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
