nastra commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238671605
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopTables.java:
##########
@@ -83,36 +76,32 @@ public void testDropTable() {
@Test
public void testDropTableWithPurge() throws IOException {
- File dataDir = temp.newFolder();
- createDummyTable(tableDir, dataDir);
+ createDummyTable(tableDir, dataDir.toFile());
Review Comment:
shall we change dataDir to `File` instead of `Path` so that we don't have to
do Path->File conversion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
