skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238669008
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -335,26 +342,26 @@ public void testListNamespace() throws Exception {
List<Namespace> nsp1 = catalog.listNamespaces(Namespace.of("db"));
Set<String> tblSet = Sets.newHashSet(nsp1.stream().map(t ->
t.toString()).iterator());
- Assert.assertEquals(3, tblSet.size());
- Assert.assertTrue(tblSet.contains("db.ns1"));
- Assert.assertTrue(tblSet.contains("db.ns2"));
- Assert.assertTrue(tblSet.contains("db.ns3"));
+ Assertions.assertThat(tblSet).hasSize(3);
+ Assertions.assertThat(tblSet).contains("db.ns1");
+ Assertions.assertThat(tblSet).contains("db.ns2");
+ Assertions.assertThat(tblSet).contains("db.ns3");
List<Namespace> nsp2 = catalog.listNamespaces(Namespace.of("db", "ns1"));
- Assert.assertEquals(1, nsp2.size());
- Assert.assertTrue(nsp2.get(0).toString().equals("db.ns1.ns2"));
+ Assertions.assertThat(nsp2).hasSize(1);
+ Assertions.assertThat(nsp2.get(0).toString()).isEqualTo("db.ns1.ns2");
List<Namespace> nsp3 = catalog.listNamespaces();
Set<String> tblSet2 = Sets.newHashSet(nsp3.stream().map(t ->
t.toString()).iterator());
- Assert.assertEquals(2, tblSet2.size());
- Assert.assertTrue(tblSet2.contains("db"));
- Assert.assertTrue(tblSet2.contains("db2"));
+ Assertions.assertThat(tblSet2).hasSize(2);
+ Assertions.assertThat(tblSet2).contains("db");
+ Assertions.assertThat(tblSet2).contains("db2");
Review Comment:
I apologize for some things not being changed, I just went through all the
code in this PR and fixed it all based on your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
