rdblue commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1257534952
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -302,10 +326,25 @@ private static <T> T childAtIndex(Predicate predicate,
int index) {
return (T) predicate.children()[index];
}
+ private static boolean
couldConvert(org.apache.spark.sql.connector.expressions.Expression expr) {
Review Comment:
How about using `canConvertToTerm` instead? That fixes a couple of issues
with the name `couldConvert`:
1. Literals can be converted, but this doesn't allow literals.
2. The word "could" is past tense, implying that the method actually
converts and then returns whether conversion was successful. But this is just
checking if the conversion would succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
