[ 
https://issues.apache.org/jira/browse/IGNITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080291#comment-16080291
 ] 

Alexey Goncharuk commented on IGNITE-5479:
------------------------------------------

Agree on all but:
 - getCheckpointPageBufferSize - this unique long is used to determine the 
default setting override.
 - fsync delay should be fine-grained enough to wait less than a millisecond 
because fsync latency itself may be 0.5 ms. Will rename this method to 
getWalFsyncDelayNanos to emphasize the different time unit

> PersistentStoreConfiguration improvements
> -----------------------------------------
>
>                 Key: IGNITE-5479
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5479
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 2.1
>            Reporter: Pavel Tupitsyn
>            Assignee: Alexey Goncharuk
>            Priority: Blocker
>             Fix For: 2.1
>
>
> Improve {{PersistentStoreConfiguration}} to be consistent with other 
> configuration classes:
> * {{LockWaitTime}} - should be {{long}} and in milliseconds
> * {{getCheckpointingPageBufferSize}} should return {{long}} instead of 
> {{Long}}
> * {{WalFlushFrequency}} - should be {{long}} and in milliseconds
> * {{WalFsyncDelay}}  - should be {{long}} and in milliseconds. Add javadoc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to