[
https://issues.apache.org/jira/browse/IGNITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080329#comment-16080329
]
Pavel Tupitsyn commented on IGNITE-5479:
----------------------------------------
Agree on fsync delay.
Do not agree on page buffer size. Internally we may maintain a nullable value,
but user-facing method must be {{long}} (otherwise it is inconsistent and
confusing; setter and getter should be of same type).
Can we do this?
{code}
public long getCheckpointingPageBufferSize() {
return checkpointingPageBufSize == null ?
DFLT_CHECKPOINTING_PAGE_BUFFER_SIZE : checkpointingPageBufSize;
}
{code}
> PersistentStoreConfiguration improvements
> -----------------------------------------
>
> Key: IGNITE-5479
> URL: https://issues.apache.org/jira/browse/IGNITE-5479
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Affects Versions: 2.1
> Reporter: Pavel Tupitsyn
> Assignee: Alexey Goncharuk
> Priority: Blocker
> Fix For: 2.1
>
>
> Improve {{PersistentStoreConfiguration}} to be consistent with other
> configuration classes:
> * {{LockWaitTime}} - should be {{long}} and in milliseconds
> * {{getCheckpointingPageBufferSize}} should return {{long}} instead of
> {{Long}}
> * {{WalFlushFrequency}} - should be {{long}} and in milliseconds
> * {{WalFsyncDelay}} - should be {{long}} and in milliseconds. Add javadoc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
