[ https://issues.apache.org/jira/browse/IGNITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080367#comment-16080367 ]
Alexey Goncharuk commented on IGNITE-5479: ------------------------------------------ This does not work: we need Long to distinguish between the following two cases: {code} new PersistentStoreConfiguration(); // Ignite will automatically adjust checkpoint buffer size {code} and {code} new PersistentStoreConfiguration().setCheckpointPageBufferSize(someValue); // Ignite will NOT adjust the checkpoint buffer size even if someValue == DEFAULT_VALUE {code} This can be solved by adding a flag isDefaultPageBufferSize on PersistentStoreConfiguration, but the approach with Long looks more clear to me. What do you think? > PersistentStoreConfiguration improvements > ----------------------------------------- > > Key: IGNITE-5479 > URL: https://issues.apache.org/jira/browse/IGNITE-5479 > Project: Ignite > Issue Type: Improvement > Components: cache > Affects Versions: 2.1 > Reporter: Pavel Tupitsyn > Assignee: Alexey Goncharuk > Priority: Blocker > Fix For: 2.1 > > > Improve {{PersistentStoreConfiguration}} to be consistent with other > configuration classes: > * {{LockWaitTime}} - should be {{long}} and in milliseconds > * {{getCheckpointingPageBufferSize}} should return {{long}} instead of > {{Long}} > * {{WalFlushFrequency}} - should be {{long}} and in milliseconds > * {{WalFsyncDelay}} - should be {{long}} and in milliseconds. Add javadoc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)