[
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116470#comment-16116470
]
Sergey Kalashnikov commented on IGNITE-5233:
--------------------------------------------
[~tledkov-gridgain]
My comments:
1. {{JdbcRequestHandler.matches()}}
using {{toUpperCase}} in {{matches()}} seems wrong. Don't we store escaped
table names in original case?
2. {{JdbcRequestHandler.getColumnsMeta()}}
{{req.cacheName()}} is passed to {{JdbcColumnMeta}} constructor, but in the
beginning of the method you had to split {{req.tableName()}} in order to get
{{cacheName}}.
3. {{JdbcRequestHandler.getColumnsMeta()}} and
{{JdbcRequestHandler.getIndexesMeta()}}
The corresponding JDBC api allows {{null}} for parameters {{schema}} and
{{table}}.
I see no checks for {{null}} for {{tableName()}} before calling
{{contains(".")}}.
4. {{JdbcRequestHandler.getPrimaryKeys()}}
It seems that logic for using {{_KEY}} or {{table.getKeyFieldName()}} is not
correct.
{{table.getKeyFieldName()}} may be {{null}} even if there are fields that are
marked as key constituents.
Moreover, the field with name {{table.getKeyFieldName()}} will also return
{{true}} for {{key()}}.
Also, error message text in the exception handler is wrong.
5. {{JdbcRequestHandler.getSchemas()}}
Wrong error message.
6. {{JdbcResult}}
Misprint in javadoc: JDBS->JDBC
Wrong javadoc for {{META_SCHEMAS}} static field.
7. {{JdbcMetaindexResult}}
default constructor assigns meta to itself.
8. {{JdbcThinParameterMetaData}}
Wrong javadoc for class header.
9. {{JdbcThinDatabaseMetadata.readonly()}}
Why we declare database read-only?
10. {{JdbcThinDatabaseMetadata.supportsMixedCaseQuotedIdentifiers()}},
{{JdbcThinDatabaseMetadata.storesUpperCaseQuotedIdentifiers()}} seems to return
incorrect value.
11. {{JdbcThinDatabaseMetadata.getIdentifierQuoteString()}}
Shouldn't it return "\"" instead of " " ?
> JDBC thin Driver: implement metadata support
> ---------------------------------------------
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
> Issue Type: Task
> Components: jdbc
> Affects Versions: 2.0
> Reporter: Taras Ledkov
> Assignee: Taras Ledkov
> Fix For: 2.2
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
