[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121402#comment-16121402
 ] 

Vladimir Ozerov commented on IGNITE-5233:
-----------------------------------------

[~tledkov-gridgain]. my comments:
1) {{JdbcThinPreparedStatement.getParameterMetaData}} - metadata must be cached 
on first access.
2) {{JdbcThinIpcIo.tablesMeta}} - unused argument
3) {{JdbcParamMeta}} -> {{JdbcParameterMeta}}
4) {{JdbcThinParameterMetaData}} -> {{JdbcThinParameterMetadata}}
5) {{JdbcThinParameterMetaData}} - no bounds check (including invalid zero of 
negatove values), please refactor it to a single method which will throw 
SQLException if parameter is invalid
6) {{JdbcThinDatabaseMetadata.getDatabaseProductVersion}} - what is "4.1.0"?
7) {{JdbcThinDatabaseMetadata.getDatabaseProductName}} - "Ignite Cache"? What 
is that? There is no such a product
8) {{JdbcThinDatabaseMetadata.getDriverName}} - should be "Ignite JDBC Thin 
Driver"
9) {{JdbcThinDatabaseMetadata.supportsConvert}} - are we really do not support 
conversions?
10) {{JdbcThinDatabaseMetadata.get*Functions}} - are we really do not support 
any?
11) {{JdbcThinDatabaseMetadata.supports*SQLGrammar}} - why false?
12) {{JdbcThinDatabaseMetadata.supports*SQL}} - why false?
13) {{JdbcThinDatabaseMetadata.supportsFullOuterJoins}} - we do not support them
14) {{JdbcThinDatabaseMetadata.supportsSchemasIn*}} - why false?
15) {{JdbcThinDatabaseMetadata.getTypeInfo}} - why empty?
16) {{JdbcThinDatabaseMetadata.supportsResultSetType}} - why true? We support 
only forward_only read_only type.
17) {{JdbcThinDatabaseMetadata.getUDTs}} - we need a ticket for this.
18) {{JdbcThinDatabaseMetadata.getDatabaseMajorVersion}} - why 1??? 
19) {{JdbcThinDatabaseMetadata.getDatabaseMinorVersion}} - why 0??? 
20) {{JdbcThinDatabaseMetadata.supportsStatementPooling}} - why false?
21) {{JdbcThinDatabaseMetadata.supportsStoredFunctionsUsingCallSyntax}} - is it 
really false?
22) {{JdbcThinDatabaseMetadata.getClientInfoProperties}} - shouldn't we list 
our connection string properties here?
23) {{JdbcThinDatabaseMetadata.getFunctions}} - why empty?

> JDBC thin Driver: implement metadata support 
> ---------------------------------------------
>
>                 Key: IGNITE-5233
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5233
>             Project: Ignite
>          Issue Type: Task
>          Components: jdbc
>    Affects Versions: 2.0
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>             Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to