[
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126985#comment-16126985
]
Vladimir Ozerov commented on IGNITE-5233:
-----------------------------------------
[~tledkov-gridgain], my comments:
1) {{SqlListenerRequestHandler.handshakeAdditionalResponse}} is a wrong
abstraction. Instead, handler should have something like {{writeHandshake}}
method
2) {{JdbcTableMeta.tblType}]} - unused field
3) {{JdbcMetaSchemasResult}} - unnecessary copying in read/write methods
4) {{JdbcMetaTablesRequest.tableTypes}} - I do not think we need to pass it
5) Make sure that {{toString}} is added to all value objects
6) {{JdbcPrimaryKeyMeta.fields}}, {{JdbcIndexMeta.fields}} - use List instead
of array to avoid unnecesasry copying and simplify the code
7) {{JdbcRequestHandler#getPrimaryKeys}} - why do we pass "_KEY" as primary key
constraint name???
8) {{JdbcRequestHandler#getTablesMeta}} - "TABLE" match can be performed on a
client, no?
> JDBC thin Driver: implement metadata support
> ---------------------------------------------
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
> Issue Type: Improvement
> Components: jdbc
> Affects Versions: 2.0
> Reporter: Taras Ledkov
> Assignee: Taras Ledkov
> Fix For: 2.2
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
