[ 
https://issues.apache.org/jira/browse/IGNITE-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694487#comment-16694487
 ] 

Yury Gerzhedovich commented on IGNITE-9777:
-------------------------------------------

[~vozerov], thanks for the review and your huge effort to fix code/name style.

My comments step by step:

1) These methods will be required for implementing statistics on query level. 

2) Agree

3) Fixed

4) Seems you are right, will be better use OffsetDateTime instead of 
LocalDateTime then it will contains TZ. However IMHO it doesn't matter which TZ 
we will use. We can keep start time in any time zone and client can convert it 
to required TZ. +Do you thinks that UTC will be good choice?+ 

5) Checked, it works, for example value from jconsole - 
2018-11-21T12:04:21.015+03:00
6) Fixed

7) Fixed

8) Fixed

9) Ok

10) Fixed

> Gathering local node IO statistics with cache and index dimensions
> ------------------------------------------------------------------
>
>                 Key: IGNITE-9777
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9777
>             Project: Ignite
>          Issue Type: Task
>          Components: persistence, sql
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: iep-27
>             Fix For: 2.8
>
>
> Should be gathered and exposed IO statistics on cache/index level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to