[
https://issues.apache.org/jira/browse/IGNITE-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813455#comment-16813455
]
Ivan Fedotov commented on IGNITE-11412:
---------------------------------------
[~Pavlukhin], I made some refactor stuff - moved logic from
{{TestJUnit3TestLegacySupport/TestConditionsAware}} to {{GridAbstractTest}} and
renamed {{setUp/tearDown}} methods. The issue with {{nameRule}} I resolved with
rule chain.
In general TC results look good [1], but I faced a problem with
{{LegacyLifecycleTest}}. I found that tests from this inner class do not work,
even from master branch. It is easy to see - you can insert output like this
{code:title=Log for bug
detection|theme=FadeToGrey|linenumbers=true|language=java|firstline=0001|collapse=true}
private void processStage(String desc, int exp, int update) {
System.out.println("exp: " + exp + " update: " + update);
Assert.assertEquals(desc + " at test class id " + testClsId, exp,
stageCnt.get());
stageCnt.set(update);
}
{code}
and it becomes clear that in master works only {{beforeTestsStarted /
afterTestsStopped}} methods. Since {{beforeTestsStarted}} method makes
replacement of {{AtomicInteger stageCnt}} on value that {{afterTestsStopped}}
expects, the test on master is green.
I went deeper and it turned out that other test methods in classes that extend
from {{IgniteConfigVariationsAbstractTest}} also do not work in master branch.
So, I created the appropriate ticket [2].
[1]
https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAllNightly&branchForTc=pull/6267/head&action=Latest
[2] https://issues.apache.org/jira/browse/IGNITE-11708
> Actualize JUnit3TestLegacySupport class
> ---------------------------------------
>
> Key: IGNITE-11412
> URL: https://issues.apache.org/jira/browse/IGNITE-11412
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Specify JUnit3TestLegacySupport class documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
