[
https://issues.apache.org/jira/browse/IGNITE-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814207#comment-16814207
]
Ivan Fedotov commented on IGNITE-11412:
---------------------------------------
[~Pavlukhin], I am not sure that null assertion for {{getName()}} is necessary
here - such assert already exists in {{GridAbstractTest}} [1]. Moreover,
{{testsCfg}} and {{testsCfgInjected}} also already initialized [2] as
{{dummyCfg()}}.
I think other {{variation}} tests are green because there are no assertions
that check test work in {{before/after}} test conditions like in
{{LegacyLifecycleTest}}. So such tests are successfully like empty code. I
inserted throwing exception in methods under {{@Test}} annotation in
{{IgniteConfigVariationsAbstractTest}} subclasses and nothing happened.
According to the current ticket, I will mark failed tests as {{Ingnore}},
right? Do you have any other suggestions to this patch?
[1]
[https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java#L183]
[2]
[https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L78]
> Actualize JUnit3TestLegacySupport class
> ---------------------------------------
>
> Key: IGNITE-11412
> URL: https://issues.apache.org/jira/browse/IGNITE-11412
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Specify JUnit3TestLegacySupport class documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
