[
https://issues.apache.org/jira/browse/IGNITE-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813717#comment-16813717
]
Ivan Pavlukhin commented on IGNITE-11412:
-----------------------------------------
[~ivanan.fed], it really good catch that {{IgniteConfigVariationsAbstractTest}}
subclasses does not work! Regarding {{nameRule}} attention should be to a
following code in {{IgniteConfigVariationsAbstractTest}}:
{code:java}
/** Manages test execution and reporting. */
private final TestRule rulePrivate = (base, description) -> new Statement() {
@Override public void evaluate() {
assert getName() != null : "getName returned null";
testsCfg = testsCfgInjected;
}
};
/** Manages first and last test execution. */
@Rule public RuleChain runRule
= RuleChain.outerRule(rulePrivate).around(super.runRule);
{code}
By some reason it _asserts_ that a _test name_ should be already defined.
I will also try to check when _config variation tests_ were broken. I believe
it worked at some point. Also I am surprised that only a small number of
_variation_ tests failed. I would like to understand why and be ensure that all
_variation_ tests does not run test methods in master at all.
In any case we should not leave new failing tests before merging the patch.
_Ignore_ or _assume_ facilities referring to a ticket with supposed fix can be
used to mark failing tests in _exceptional_ cases. Problem with _variation_
tests looks like such _exceptional_ case.
> Actualize JUnit3TestLegacySupport class
> ---------------------------------------
>
> Key: IGNITE-11412
> URL: https://issues.apache.org/jira/browse/IGNITE-11412
> Project: Ignite
> Issue Type: Improvement
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Specify JUnit3TestLegacySupport class documentation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
