[
https://issues.apache.org/jira/browse/IGNITE-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907948#comment-16907948
]
Ivan Pavlukhin commented on IGNITE-7285:
----------------------------------------
[~samaitra], from configuration standpoint changes look good. But a default
value is not passed properly. Method {{GridCacheQueryAdapter#timeout(long)}}
using _default timeout_ from configuration is never used in a production code,
so I suppose that a timeout is not propagated properly. In API we have 2 types
of queries supporting timeouts {{SqlFieldsQuery}} and {{SqlQuery}}.
Mechanically {{QueryParameters#fromQuery}} looks as a good starting point to
see how timeout is propagated from a user {{SqlFieldsQuery}} for an actual
execution. Note, that timeout should be propagated to _map_ queries as well.
Also, all behavior should be validated by tests, at least following execution
modes should be covered:
* Distributed query against PARTITIONED cache.
* Distributed query against REPLICATED cache.
* Local query.
> Add default query timeout
> -------------------------
>
> Key: IGNITE-7285
> URL: https://issues.apache.org/jira/browse/IGNITE-7285
> Project: Ignite
> Issue Type: Improvement
> Components: cache, sql
> Affects Versions: 2.3
> Reporter: Valentin Kulichenko
> Assignee: Saikat Maitra
> Priority: Major
> Labels: sql-stability
> Fix For: 2.8
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently it's possible to provide timeout only on query level. It would be
> very useful to have default timeout value provided on cache startup. Let's
> add {{CacheConfiguration#defaultQueryTimeout}} configuration property.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
