[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960818#comment-16960818
]
Ivan Bessonov commented on IGNITE-12108:
----------------------------------------
[~nizhikov] can you please explain why it's a poor design and why it has to be
fixed in this particular issue?
I wanted to introduce metrics for Communication SPI, not for every other
component that uses NIO server. If you want me to do it then please create
separate issue.
> It's about unnecessary {{Map#get}} operation.
That method is deprecated and invoked in JMX only, should I really care about
rare single get operation? I don't think so.
> Please, revert unnecessary changes.
Do we have any strict rules about removing unnecessary "this." references in
code?
I mean, it's not hard for me to return everything back, but how should I
initialize new field, "this.ctx = ...;" or "ctx = ...;"? What was the
motivation behind your comment?
Please reply, thank you!
> [IEP-35] Migrate Communication Metrics.
> ---------------------------------------
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.<directType>|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.<directType>|Total number of
> messages with given type received by current node|
> |communication.tcp.<nodeId>.sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp.<nodeId>.receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
