[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960838#comment-16960838
]
Nikolay Izhikov commented on IGNITE-12108:
------------------------------------------
> I wanted to introduce metrics for Communication SPI
All I ask you regarding this PR is to avoid Nullable constructor params.
Can we do it?
> That method is deprecated and invoked in JMX only, should I really care about
> rare single get operation?
1.. Yes you should, because, many existing deployments use existing metrics.
It takes time for it to migrate on the new framework.
2. It's easy to fix, please, do it.
> What was the motivation behind your comment?
You should avoid any unnecessary changes in the codebase for the sake of review
simplicity.
{this} fixes are unnecessary. Please, revert them in this PR.
If you want to refactor it I propose the better way:
1. Discuss this code style point on the dev-list.
2. Find checkstyle rule to automatically check it.
3. Refactor all Ignite codebase in single commit to the preferred assignment
style
WDYT?
> [IEP-35] Migrate Communication Metrics.
> ---------------------------------------
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.<directType>|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.<directType>|Total number of
> messages with given type received by current node|
> |communication.tcp.<nodeId>.sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp.<nodeId>.receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
