[
https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962828#comment-16962828
]
Ivan Bessonov commented on IGNITE-12108:
----------------------------------------
[~nizhikov]
> All I ask you regarding this PR is to avoid Nullable constructor params.
One of those constructors (GridNioServer) already had nullable parameter,
should I eliminate it as well? And what's the point of having two constructors
instead of one in abstract class (GridAbstractCommunicationClient)? It won't
make the code more readable.
Everything else is fine, I'll commit that changes soon.
> [IEP-35] Migrate Communication Metrics.
> ---------------------------------------
>
> Key: IGNITE-12108
> URL: https://issues.apache.org/jira/browse/IGNITE-12108
> Project: Ignite
> Issue Type: New Feature
> Reporter: Ivan Bessonov
> Assignee: Ivan Bessonov
> Priority: Major
> Labels: IEP-35, await
> Fix For: 2.8
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be
> sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current
> node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by
> current node|
> |communication.tcp.sentMessagesByType.<directType>|Total number of messages
> with given type sent by current node|
> |communication.tcp.receivedMessagesByType.<directType>|Total number of
> messages with given type received by current node|
> |communication.tcp.<nodeId>.sentMessagesToNode|Total number of messages sent
> by current node to the given node|
> |communication.tcp.<nodeId>.receivedMessagesFromNode|Total number of messages
> received by current node from the given node|
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
