[
https://issues.apache.org/jira/browse/IGNITE-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034681#comment-17034681
]
Andrey N. Gura commented on IGNITE-10698:
-----------------------------------------
[~l4ndsc4pe] Could you please fix checkstyle issues:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (style) on project
ignite-core: Failed during checkstyle execution: There are 21 errors reported
by Checkstyle 8.19 with ../checkstyle/checkstyle.xml ruleset. -> [Help 1]
{noformat}
For example you can run build locally with the following command:
{noformat}
mvn clean install -DskipTests -Dmaven.javadoc.skip=true -P checkstyle,lgpl
{noformat}
Also please look at Apache Ignite code style guidelines:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
Do not ignore this guidelines and javadocs.
> Get rid of @MXBeanParametersNames and @MXBeanParametersDescriptions
> -------------------------------------------------------------------
>
> Key: IGNITE-10698
> URL: https://issues.apache.org/jira/browse/IGNITE-10698
> Project: Ignite
> Issue Type: Task
> Reporter: Yakov Zhdanov
> Assignee: Lev Kiselev
> Priority: Major
> Labels: newbie, pull-request-available, usability
> Fix For: 3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> @MXBeanDescription("Returns or kills transactions matching the filter
> conditions.")
> @MXBeanParametersNames(
> {
> "minDuration",
> "minSize",
> "prj",
> "consistentIds",
> "xid",
> "lbRegex",
> "limit",
> "order",
> "detailed",
> "kill"
> }
> )
> @MXBeanParametersDescriptions(
> {
> "Minimum duration (seconds).",
> "Minimum size.",
> "Projection (servers|clients).",
> "Consistent ids (separated by comma).",
> "Transaction XID.",
> "Label regexp.",
> "Limit a number of transactions collected on each node.",
> "Order by DURATION|SIZE.",
> "Show detailed description, otherwise only count.",
> "Kill matching transactions (be careful)."
> }
> )
> {noformat}
> Above looks pretty ugly and is very error prone due to messing names and
> descr order or number of strings.
> I would suggest to introduce individual parameters annotations and get them
> via mtd.getParamterAnnotations() at runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
