[
https://issues.apache.org/jira/browse/IGNITE-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038262#comment-17038262
]
Andrey N. Gura commented on IGNITE-10698:
-----------------------------------------
[~l4ndsc4pe] Thanks for your effort. Tests set is impressive ) Nevertheless, I
have comments to PR (most of them just cosmetic). Could you please fix them?
Also I found that new tests expect {{AssertionError}} which will not be thrown
if assertions are disabled (it's default). I believe it is out of scope and
could be solved as separate issue if you wish.
> Get rid of @MXBeanParametersNames and @MXBeanParametersDescriptions
> -------------------------------------------------------------------
>
> Key: IGNITE-10698
> URL: https://issues.apache.org/jira/browse/IGNITE-10698
> Project: Ignite
> Issue Type: Task
> Reporter: Yakov Zhdanov
> Assignee: Lev Kiselev
> Priority: Major
> Labels: newbie, usability
> Fix For: 2.9
>
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> {noformat}
> @MXBeanDescription("Returns or kills transactions matching the filter
> conditions.")
> @MXBeanParametersNames(
> {
> "minDuration",
> "minSize",
> "prj",
> "consistentIds",
> "xid",
> "lbRegex",
> "limit",
> "order",
> "detailed",
> "kill"
> }
> )
> @MXBeanParametersDescriptions(
> {
> "Minimum duration (seconds).",
> "Minimum size.",
> "Projection (servers|clients).",
> "Consistent ids (separated by comma).",
> "Transaction XID.",
> "Label regexp.",
> "Limit a number of transactions collected on each node.",
> "Order by DURATION|SIZE.",
> "Show detailed description, otherwise only count.",
> "Kill matching transactions (be careful)."
> }
> )
> {noformat}
> Above looks pretty ugly and is very error prone due to messing names and
> descr order or number of strings.
> I would suggest to introduce individual parameters annotations and get them
> via mtd.getParamterAnnotations() at runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
