[
https://issues.apache.org/jira/browse/IGNITE-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035358#comment-17035358
]
Lev Kiselev commented on IGNITE-10698:
--------------------------------------
[~agura], thanks for your comment. The problem was, that every class field must
have empty space after it's declaring. And that's confusing, because I
configured code style and code inspection in my IDE and none of this helped to
detect the problem right away. I'm omw to fix this and add javadocs to test
methods.
> Get rid of @MXBeanParametersNames and @MXBeanParametersDescriptions
> -------------------------------------------------------------------
>
> Key: IGNITE-10698
> URL: https://issues.apache.org/jira/browse/IGNITE-10698
> Project: Ignite
> Issue Type: Task
> Reporter: Yakov Zhdanov
> Assignee: Lev Kiselev
> Priority: Major
> Labels: newbie, pull-request-available, usability
> Fix For: 3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> @MXBeanDescription("Returns or kills transactions matching the filter
> conditions.")
> @MXBeanParametersNames(
> {
> "minDuration",
> "minSize",
> "prj",
> "consistentIds",
> "xid",
> "lbRegex",
> "limit",
> "order",
> "detailed",
> "kill"
> }
> )
> @MXBeanParametersDescriptions(
> {
> "Minimum duration (seconds).",
> "Minimum size.",
> "Projection (servers|clients).",
> "Consistent ids (separated by comma).",
> "Transaction XID.",
> "Label regexp.",
> "Limit a number of transactions collected on each node.",
> "Order by DURATION|SIZE.",
> "Show detailed description, otherwise only count.",
> "Kill matching transactions (be careful)."
> }
> )
> {noformat}
> Above looks pretty ugly and is very error prone due to messing names and
> descr order or number of strings.
> I would suggest to introduce individual parameters annotations and get them
> via mtd.getParamterAnnotations() at runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
