[
https://issues.apache.org/jira/browse/IGNITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576834#comment-14576834
]
Atri Sharma commented on IGNITE-917:
------------------------------------
Thanks for your comments.
1) I have fixed the line problem. The problem is that I am used to BSD style
which mandates these lines and all, so I will take some time to accustom to
Ignite guidelines. Sorry about that.
2) Fixed
3) Fixed
4) For test, I was not sure what is the cleanest way to implement same. I have
added test according to what I could gather from existing tests and to my
knowledge. The problem is that I could not find method to get all hosts for
given ClusterGroup. The test implementation might not be most optimal but that
is open for discussion.
Please see and let me know your feedback and comments.
> Add org.apache.ignite.cluster.ClusterGroup.forHost(String host, String...
> hosts) overload
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-917
> URL: https://issues.apache.org/jira/browse/IGNITE-917
> Project: Ignite
> Issue Type: Task
> Components: newbie
> Reporter: Yakov Zhdanov
> Assignee: Yakov Zhdanov
> Attachments: ignite-sprint-5_ignite-917ver3.patch
>
>
> Method should build a cluster group from all nodes running on the hosts
> specified.
> This should be dynamic group. I think method implementation should build up a
> predicate to check that passed in node's host names contain one of the host
> names from parameters.
> See IgnitePredicate, ClusterGroup, ClusterNode, ClusterNode#hostNames
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
