[
https://issues.apache.org/jira/browse/IGNITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579322#comment-14579322
]
Artem Shutak commented on IGNITE-917:
-------------------------------------
Hi, Atri,
Look really better. I think Yakov or someone else from commiters should look at
it.
I suggest to fix next things, before somobody else will review your patch:
- You still have formatting issues.
See indents and extra spaces.
Instead of testforHostString have to be testForHostString (but I'd like just
testForHost).
Instead of '@param host' should be '@param {b}H{b}ost'.
- Ok, I see you create HashSet once - great! But for what you created
ArrayList-s before? Why not to fill Set immediately?
- I do not sure about your test. I think you can check more than you do.
> Add org.apache.ignite.cluster.ClusterGroup.forHost(String host, String...
> hosts) overload
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-917
> URL: https://issues.apache.org/jira/browse/IGNITE-917
> Project: Ignite
> Issue Type: Task
> Components: newbie
> Reporter: Yakov Zhdanov
> Assignee: Yakov Zhdanov
> Attachments: ignite-sprint-5_ignite-917ver9.patch
>
>
> Method should build a cluster group from all nodes running on the hosts
> specified.
> This should be dynamic group. I think method implementation should build up a
> predicate to check that passed in node's host names contain one of the host
> names from parameters.
> See IgnitePredicate, ClusterGroup, ClusterNode, ClusterNode#hostNames
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
