[
https://issues.apache.org/jira/browse/IGNITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577647#comment-14577647
]
Artem Shutak commented on IGNITE-917:
-------------------------------------
Your patch cannot be applied to ignite-sprint-5 (see any build results). Merge
with it before to create patch file.
I see you don't fix performance issues at HostsFilter#apply (see point 4 my
last review).
And again, as 2 comments before, reread
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracketsandIdentation.
> Add org.apache.ignite.cluster.ClusterGroup.forHost(String host, String...
> hosts) overload
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-917
> URL: https://issues.apache.org/jira/browse/IGNITE-917
> Project: Ignite
> Issue Type: Task
> Components: newbie
> Reporter: Yakov Zhdanov
> Assignee: Yakov Zhdanov
> Attachments: ignite-sprint-5_ignite-917ver6.patch
>
>
> Method should build a cluster group from all nodes running on the hosts
> specified.
> This should be dynamic group. I think method implementation should build up a
> predicate to check that passed in node's host names contain one of the host
> names from parameters.
> See IgnitePredicate, ClusterGroup, ClusterNode, ClusterNode#hostNames
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
