git-hulk commented on PR #1032:
URL:
https://github.com/apache/incubator-kvrocks/pull/1032#issuecomment-1290279358
@PragmaTwice After looking through the PR, I was a bit worry that it needs
to take some time (include myself) to understand how to use it and how it
works. And for Redis command arguments, there're only three argument types:
* string
* bool, like NX/EX/PX and so on
* number(int/float) like TTL and score
So I'm wondering if we can simplify the parser API like below:
```C++
while(token = parse.next()) {
switch tolower(token):
case "ex":
status = parser.expect<int>(&ttl)
case "px":
status = parser.expect<int64_t>(&ttl_ms)
...
}
```
So that users can only concern token and what's next is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
