torwig commented on code in PR #1032:
URL:
https://github.com/apache/incubator-kvrocks/pull/1032#discussion_r1007274247
##########
tests/gocase/unit/type/strings/strings_test.go:
##########
@@ -605,12 +605,12 @@ func TestString(t *testing.T) {
})
t.Run("Extended SET with incorrect expire value", func(t *testing.T) {
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"exat", "0").Err(), "invalid expire time")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "1234xyz").Err(), "not an integer")
- require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar",
"pxat", "0").Err(), "invalid expire time")
+ require.ErrorContains(t, rdb.Do(ctx, "SET", "foo", "bar", "ex",
"1234xyz").Err(), "non-integer")
Review Comment:
Yes, you are right, it's not easy to keep identical error messages. Since
Redis doesn't have error codes, I was wondering if Redis-clients parse error
messages to get something useful from them or just signal error/no-error? Does
error message be considered a part of Redis-protocol?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
