PragmaTwice commented on PR #1342: URL: https://github.com/apache/incubator-kvrocks/pull/1342#issuecomment-1480713750
> I intentionally use seconds and explicit false as the last parameter of a constructor to model the current encoding of metadata. And then I'm decoding that metadata with the new version by passing explicit true as the last parameter to the constructor. `metadata.expire` now cannot be seconds. It must be milliseconds, and when it is encoded to some raw data, it will be converted to seconds for `use_64bit_common_field=false`. Your test is added to the codebase, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
