PragmaTwice commented on PR #1342: URL: https://github.com/apache/incubator-kvrocks/pull/1342#issuecomment-1480876787
> Can some stale versions of kvrocks recognize this format? If user ENABLE it, and find other bug, and revert kvrocks to a old version. Would user get segment fault on these keys? Firstly, we currently do not enable this new encoding by default. And if users write some data via the new encoding, they cannot revert their kvrocks version to 2.3.0 or earlier. But if we release 2.4.0 and keep `ENABLE_NEW_ENCODING=OFF`, and then release 2.5.0 to turn on it as default, the users can revert their version from 2.5.0 to 2.4.0 without any data breaking. BTW, I think any encoding changes may be a pain to users, which is not specially related to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
