PragmaTwice commented on code in PR #1342:
URL:
https://github.com/apache/incubator-kvrocks/pull/1342#discussion_r1145930552
##########
src/storage/redis_metadata.cc:
##########
@@ -145,33 +147,39 @@ void ComposeSlotKeyPrefix(const Slice &ns, int slotid,
std::string *output) {
PutFixed16(output, static_cast<uint16_t>(slotid));
}
-Metadata::Metadata(RedisType type, bool generate_version)
- : flags((uint8_t)0x0f & type), expire(0), version(0), size(0) {
- if (generate_version) version = generateVersion();
-}
+Metadata::Metadata(RedisType type, bool generate_version, bool
use_64bit_common_field)
+ : flags((use_64bit_common_field ? METADATA_64BIT_ENCODING_MASK : 0) |
(METADATA_TYPE_MASK & type)),
Review Comment:
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
