mapleFU commented on code in PR #2174:
URL: https://github.com/apache/kvrocks/pull/2174#discussion_r1527024657
##########
src/search/indexer.cc:
##########
@@ -38,7 +38,7 @@ StatusOr<FieldValueRetriever>
FieldValueRetriever::Create(SearchOnDataType type,
Hash db(storage, ns);
std::string ns_key = db.AppendNamespacePrefix(key);
HashMetadata metadata(false);
- auto s = db.GetMetadata(ns_key, &metadata);
+ auto s = db.GetMetadata(Database::GetOptions{}, ns_key, &metadata);
Review Comment:
I thought of add a method with default GetOption, applying a rule implicitly
might break the consistency of system, .i.e, we may tent to use `GetMetadata`
in default function and forget to use snapshot when we should do like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
