git-hulk commented on code in PR #2174:
URL: https://github.com/apache/kvrocks/pull/2174#discussion_r1527447944
##########
src/search/indexer.cc:
##########
@@ -38,7 +38,7 @@ StatusOr<FieldValueRetriever>
FieldValueRetriever::Create(SearchOnDataType type,
Hash db(storage, ns);
std::string ns_key = db.AppendNamespacePrefix(key);
HashMetadata metadata(false);
- auto s = db.GetMetadata(ns_key, &metadata);
+ auto s = db.GetMetadata(Database::GetOptions{}, ns_key, &metadata);
Review Comment:
I feel good about it's also easy to break if don't understand why we need to
use the snapshot in some places. But the current implementation is also good to
me. To see if other folks have thoughts on this. @PragmaTwice @torwig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
