PragmaTwice commented on code in PR #2174:
URL: https://github.com/apache/kvrocks/pull/2174#discussion_r1527449640
##########
src/search/indexer.cc:
##########
@@ -38,7 +38,7 @@ StatusOr<FieldValueRetriever>
FieldValueRetriever::Create(SearchOnDataType type,
Hash db(storage, ns);
std::string ns_key = db.AppendNamespacePrefix(key);
HashMetadata metadata(false);
- auto s = db.GetMetadata(ns_key, &metadata);
+ auto s = db.GetMetadata(Database::GetOptions{}, ns_key, &metadata);
Review Comment:
Actually not only for `GetMetadata`, I think we should also make snapshot as
a parameter in other methods. So we'd better more careful about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
