PragmaTwice commented on code in PR #2750:
URL: https://github.com/apache/kvrocks/pull/2750#discussion_r1932200158
##########
src/types/redis_hash.h:
##########
@@ -56,7 +56,7 @@ class Hash : public SubKeyScanner {
rocksdb::Status IncrByFloat(engine::Context &ctx, const Slice &user_key,
const Slice &field, double increment,
double *new_value);
rocksdb::Status MSet(engine::Context &ctx, const Slice &user_key, const
std::vector<FieldValue> &field_values,
- bool nx, uint64_t *added_cnt);
+ bool nx, uint64_t *added_cnt, uint64_t ttl = -1);
Review Comment:
```suggestion
bool nx, uint64_t *added_cnt, uint64_t expire = 0);
```
better to be 0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
