PragmaTwice commented on PR #2750: URL: https://github.com/apache/kvrocks/pull/2750#issuecomment-2621828284
I just found one issue about the command name: HSETEX. HSETEX can be HSET + EXPIRE, but it also can be HSET + HEXPIRE (with the hash field expiration). Redis doesn't have this command (and, potentially will add this command in the future). Dragonfly has this command (https://www.dragonflydb.io/docs/command-reference/hashes/hsetex), which means HSET + HEXPIRE. So if we add this, there's a potentially semantic inconsistence: if Redis add it in the future and the Redis one means HSET + HEXPIRE, we'll have a trouble, i.e. we will be incompatible to Redis, otherwise incompatible to previous version of Kvrocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
