ltagliamonte-dd commented on code in PR #2750:
URL: https://github.com/apache/kvrocks/pull/2750#discussion_r1932222102
##########
src/commands/cmd_hash.cc:
##########
@@ -258,6 +259,36 @@ class CommandHMSet : public Commander {
std::vector<FieldValue> field_values_;
};
+class CommandHSetEx : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ if (args.size() < 5) {
+ return {Status::RedisParseErr, errWrongNumOfArguments};
+ }
+ ttl_ = GET_OR_RET(ParseInt<int64_t>(args[2], 10));
Review Comment:
addressed via 76b25447b94878bfc75da31b30b6f7bcad5fce4f
##########
src/types/redis_hash.h:
##########
@@ -56,7 +56,7 @@ class Hash : public SubKeyScanner {
rocksdb::Status IncrByFloat(engine::Context &ctx, const Slice &user_key,
const Slice &field, double increment,
double *new_value);
rocksdb::Status MSet(engine::Context &ctx, const Slice &user_key, const
std::vector<FieldValue> &field_values,
- bool nx, uint64_t *added_cnt);
+ bool nx, uint64_t *added_cnt, uint64_t ttl = -1);
Review Comment:
addressed via 76b25447b94878bfc75da31b30b6f7bcad5fce4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
