git-hulk commented on code in PR #271:
URL:
https://github.com/apache/kvrocks-controller/pull/271#discussion_r1986338988
##########
controller/cluster.go:
##########
@@ -228,11 +235,38 @@ func (c *ClusterChecker) parallelProbeNodes(ctx
context.Context, cluster *store.
zap.Int64("node.version",
version),
zap.Int64("clusterName.version", clusterVersion),
).Warn("The node is in a higher
version")
+ mu.Lock()
+ if version > latestNodeVersion {
+ latestNodeVersion = version
+ clusterNodesStr, errX :=
n.GetClusterNodesString(ctx)
+ if errX != nil {
+
log.With(zap.String("node", node.ID()), zap.Error(errX)).Error("Failed to get
the cluster nodes info from node")
+ }
+ latestClusterNodesStr =
clusterNodesStr
Review Comment:
I think it would be better to handle the error here. We can only print the
error log and don't update the `latestClusterNodesStr`, then it will retry at
the next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
