git-hulk commented on code in PR #271:
URL: 
https://github.com/apache/kvrocks-controller/pull/271#discussion_r2015907089


##########
controller/cluster.go:
##########
@@ -228,11 +235,41 @@ func (c *ClusterChecker) parallelProbeNodes(ctx 
context.Context, cluster *store.
                                                zap.Int64("node.version", 
version),
                                                
zap.Int64("clusterName.version", clusterVersion),
                                        ).Warn("The node is in a higher 
version")
+                                       mu.Lock()
+                                       if version > latestNodeVersion {
+                                               latestNodeVersion = version

Review Comment:
   @greatsharp Could you please have a look at this comment, and we can get it 
merge after resolving this comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to