Copilot commented on code in PR #271:
URL:
https://github.com/apache/kvrocks-controller/pull/271#discussion_r1990419125
##########
controller/cluster.go:
##########
@@ -228,11 +235,41 @@ func (c *ClusterChecker) parallelProbeNodes(ctx
context.Context, cluster *store.
zap.Int64("node.version",
version),
zap.Int64("clusterName.version", clusterVersion),
).Warn("The node is in a higher
version")
+ mu.Lock()
+ if version > latestNodeVersion {
+ latestNodeVersion = version
Review Comment:
If a node with a higher version fails to return valid cluster info
(resulting in an empty string), it overrides previously stored valid data from
a lower version node. Consider storing both the version and its associated info
together and only updating the stored info when the retrieval succeeds.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
